Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.86%. Comparing base (76540cc) to head (d46df8b).
Report is 5 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1349      +/-   ##
==========================================
- Coverage   72.86%   72.86%   -0.01%     
==========================================
  Files         137      137              
  Lines       14515    14516       +1     
==========================================
  Hits        10577    10577              
- Misses       3938     3939       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morcuended Are the loggers of the script and of the called functions independent? Should I pass the logging level explicitly as an argument of find_tailcuts? I want it always set to "info", so the original code should do.

In principle not, I think it should be controlled by the level set in the main script calling the other module (see example at the top of https://docs.python.org/3/library/logging.html). Maybe need to set explicitly the level for file handler as well.

In lstchain_find_tailcuts.py

def main():
    args = parser.parse_args()

    output_dir = args.output_dir.absolute()
    output_dir.mkdir(exist_ok=True, parents=True)

    log.setLevel(logging.INFO)
    
    # Console handler
    console_handler = logging.StreamHandler(sys.stdout)
    console_handler.setLevel(logging.INFO)
    logging.getLogger().addHandler(console_handler)

    # File handler
    log_file = args.log_file or f'log_find_tailcuts_Run{run_id:05d}.log'
    log_file = output_dir / log_file
    file_handler = logging.FileHandler(log_file, mode='w')
    file_handler.setLevel(logging.INFO)
    logging.getLogger().addHandler(file_handler)
    ...

I will try, thanks a lot for the info!

Adding the console handler resulted in duplication of the (incomplete) output in stdout.
Then adding the setting for the file handler did not help either. Will keep trying.

@morcuended I tried to follow the suggestions in the link you sent and did not help. The only way I seem to be able to activate INFO logging is inside cleaning.py

I think you need to specify which module you are specifying the log level for. For exemple this is how I set up the logging level for BaccMod in a notebook :

from baccmod import RadialAcceptanceMapCreator, Grid3DAcceptanceMapCreator
logging.getLogger('baccmod').setLevel(logging.WARNING)

The name used can be on a of any scope (package, module).
So here you could do :

logging.getLogger('lstchain.image.cleaning').setLevel(logging.INFO)
in lstchain_find_tailcuts.py

I think you need to specify which module you are specifying the log level for. For exemple this is how I set up the logging level for BaccMod in a notebook :

from baccmod import RadialAcceptanceMapCreator, Grid3DAcceptanceMapCreator
logging.getLogger('baccmod').setLevel(logging.WARNING)

The name used can be on a of any scope (package, module). So here you could do :

logging.getLogger('lstchain.image.cleaning').setLevel(logging.INFO) in lstchain_find_tailcuts.py

Thanks, that's it indeed. I will do it like that.

Good! For me, it is still a mystery that you cannot control the level with the root logger, without having to specify explicitly the submodule, but for all lstchain modules at the same time. Maybe I'm misunderstanding something from the logging system.

@moralejo, are the rest of INFO messages from other parts of the code shown as well?

Good! For me, it is still a mystery that you cannot control the level with the root logger, without having to specify explicitly the submodule, but for all lstchain modules at the same time. Maybe I'm misunderstanding something from the logging system.

@moralejo, are the rest of INFO messages from other parts of the code shown as well?

You can set the level for all lstchain in one go with
logging.getLogger('lstchain').setLevel(logging.INFO)

Current implementation will show the INFO messages of the script itself (level defined in line 51) and of methods in lstchain.image.cleaning' but not from elsewhere.

You can set the level for all lstchain in one go with logging.getLogger('lstchain').setLevel(logging.INFO)

Current implementation will show the INFO messages of the script itself (level defined in line 51) and of methods in lstchain.image.cleaning' but not from elsewhere.

I think I see now my wrong understanding.

log = logging.getLogger(__name__)
def main():
    args = parser.parse_args()
log.setLevel(logging.INFO)

setLevel here only acts over log, defined within the file scope, but not setting it anywhere else (as I thought it was doing, like if it was the root logger acting across all submodules).

Keep in mind that no other INFO message (default is WARNING) will appear outside image.cleaning or this script as @gabemery says, unless defining it lstchain module-wise.

@moralejo, are the rest of INFO messages from other parts of the code shown as well?

I got the same output as when I defined the level inside the function

You can set the level for all lstchain in one go with logging.getLogger('lstchain').setLevel(logging.INFO)

Current implementation will show the INFO messages of the script itself (level defined in line 51) and of methods in lstchain.image.cleaning' but not from elsewhere.

Yes, but this is what I want here.

setLevel here only acts over log, defined within the file scope, but not setting it anywhere else (as I thought it was doing, like if it was the root logger acting across all submodules).

Keep in mind that no other INFO message (default is WARNING) will appear outside image.cleaning or this script as @gabemery says, unless defining it lstchain module-wise.

Ok, thanks! Not a problem in this case.